This repository has been archived by the owner on Apr 8, 2021. It is now read-only.
ISC-379: ElasticLogSource implementation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aninhumer
commented
Jan 30, 2018
•
aninhumer
commented
- Re-target to master after Initial release #1 is merged.
carlpulley
suggested changes
Jan 30, 2018
| // $COVERAGE-OFF$ disabled until this is implemented | ||
| import scala.util.control.NonFatal | ||
|
|
||
| class ElasticSearchLogSource(id: String, logStreamName: String) |
There was a problem hiding this comment.
Here, maybe id and logStreamName should be treated as the same thing?
I'd also suggest that we might want to pass in a query parameter here as well? I'm thinking it might be a good idea to filter out noise prior to use parsing log lines.
| val awsLogClient = AWSLogsAsyncClientBuilder.defaultClient() | ||
| val logStream = new GetLogEventsRequest() | ||
| .withLogStreamName(logStreamName) | ||
| .withStartFromHead(false) |
There was a problem hiding this comment.
Maybe where we start from can be defined via our initial stream query?
|
|
||
| object DockerLogSource { | ||
|
|
||
| final case class ProcessTerminated(exitCode: Int) |
There was a problem hiding this comment.
Should this be in core module rather than in the instrumentation/docker module?
carlpulley
suggested changes
Jan 30, 2018
| * | ||
| * @tparam A type of the unmarshalled logging instance | ||
| */ | ||
| trait SubscriberPollingLoggingSource[A] extends LoggingSource[A] { |
There was a problem hiding this comment.
Perhaps SubscriberLoggingSource would be sufficient here?
carlpulley
reviewed
Jan 30, 2018
| // $COVERAGE-ON$ | ||
| Observable | ||
| .fromFuture( | ||
| Future(awsLogClient.getLogEventsAsync(logStream).get()) |
There was a problem hiding this comment.
Ugly, but what sadly is necessary with Java futures!
aninhumer
force-pushed
the
feature/ISC-379-elastic-log-source
branch
from
c50398e
to
eb52139
Compare
added 7 commits
February 8, 2018 10:21
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.